[
https://issues.apache.org/jira/browse/BEAM-6356?focusedWorklogId=249568&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249568
]
ASF GitHub Bot logged work on BEAM-6356:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 18:33
Start Date: 28/May/19 18:33
Worklog Time Spent: 10m
Work Description: qinyeli commented on pull request #8687: [BEAM-6356]
Add the option to use TFRecord to store cache results using PCollection's PCoder
URL: https://github.com/apache/beam/pull/8687#discussion_r288243671
##########
File path: sdks/python/apache_beam/runners/interactive/cache_manager.py
##########
@@ -56,6 +64,9 @@ def _latest_version(self, *labels):
def read(self, *labels):
"""Return the PCollection as a list as well as the version number.
+ Args:
+ *labels: List of labels for PCollection instance.
+
Returns:
(List[PCollection])
Review comment:
It's probably not List[PCollection], but List[Items in PCollection] or
PCollection as a List.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249568)
Time Spent: 1h 10m (was: 1h)
Remaining Estimate: 166h 50m (was: 167h)
> Python FileBasedCacheManager does not respect PCoder for PCollection being
> cached
> ----------------------------------------------------------------------------------
>
> Key: BEAM-6356
> URL: https://issues.apache.org/jira/browse/BEAM-6356
> Project: Beam
> Issue Type: Improvement
> Components: examples-python
> Reporter: Hennadiy Leontyev
> Assignee: Qinye Li
> Priority: Minor
> Original Estimate: 168h
> Time Spent: 1h 10m
> Remaining Estimate: 166h 50m
>
> FileBasedCacheManager used by Python's InteractiveRunner does not preserve
> PCoder for elements of a PCollection being cached on disk. I suggest that the
> cache on-disk format to be changed to TFRecords (which are supported by Beam)
> and FileBasedCacheManager would store the desired PCoder for cached
> collections.
> Currently, it is not possible to work with dynamically-generated protocol
> buffer messages in interactive runner mode because of pickling errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
