[ 
https://issues.apache.org/jira/browse/BEAM-6777?focusedWorklogId=251886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-251886
 ]

ASF GitHub Bot logged work on BEAM-6777:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/19 16:58
            Start Date: 31/May/19 16:58
    Worklog Time Spent: 10m 
      Work Description: robinyqiu commented on pull request #8681: [BEAM-6777] 
Add enable_health_checker flag for Dataflow FnAPI worker (Python)
URL: https://github.com/apache/beam/pull/8681#discussion_r289470484
 
 

 ##########
 File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py
 ##########
 @@ -500,6 +500,34 @@ def test_experiment_use_multiple_sdk_containers(self):
     self.assertNotIn(
         "use_multiple_sdk_containers", environment.proto.experiments)
 
+  def test_experiment_enable_health_checker(self):
+    pipeline_options = PipelineOptions(
+        ['--project', 'test_project', '--job_name', 'test_job_name',
+         '--temp_location', 'gs://test-location/temp',
+         '--experiments', 'beam_fn_api'])
+    environment = apiclient.Environment(
+        [], pipeline_options, 1, FAKE_PIPELINE_URL)
+    self.assertIn("enable_health_checker", environment.proto.experiments)
 
 Review comment:
   Done. Thanks for paying attention to style issue.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 251886)
    Time Spent: 3h 40m  (was: 3.5h)

> SDK Harness Resilience
> ----------------------
>
>                 Key: BEAM-6777
>                 URL: https://issues.apache.org/jira/browse/BEAM-6777
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Sam Rohde
>            Assignee: Yueyang Qiu
>            Priority: Major
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> If the Python SDK Harness crashes in any way (user code exception, OOM, etc) 
> the job will hang and waste resources. The fix is to add a daemon in the SDK 
> Harness and Runner Harness to communicate with Dataflow to restart the VM 
> when stuckness is detected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to