[
https://issues.apache.org/jira/browse/BEAM-7470?focusedWorklogId=252168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252168
]
ASF GitHub Bot logged work on BEAM-7470:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/19 00:55
Start Date: 01/Jun/19 00:55
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8733: [BEAM-7470]
Update proto and all SDKs to make the logical data stream over the data plane
identified solely by instruction id and transform id.
URL: https://github.com/apache/beam/pull/8733#discussion_r289585214
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -520,18 +504,15 @@ message ProcessBundleSplitResponse {
// (Required) The grpc read transform reading this channel.
string ptransform_id = 1;
- // (Required) Name of the transform's input to which to pass the element.
- string input_id = 2;
-
// The last element of the input channel that should be entirely considered
// part of the primary, identified by its absolute index in the (ordered)
// channel.
- int32 last_primary_element = 3;
+ int32 last_primary_element = 2;
// The first element of the input channel that should be entirely
considered
// part of the residual, identified by its absolute index in the (ordered)
// channel.
- int32 first_residual_element = 4;
+ int32 first_residual_element = 3;
Review comment:
I assume Portable pipelines aren't currently likely to be "updated" by
users, which would make the proto re-numbering safe? That is, Portability is
still notionally experimental, at least WRT work splitting?
Otherwise this could cause mismatches between an SDK with splitting, and a
runner that supports splitting, and they wouldn't be able to communicate
correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 252168)
Time Spent: 40m (was: 0.5h)
> Clean up Data Plane, rely only on instruction id and transform id
> -----------------------------------------------------------------
>
> Key: BEAM-7470
> URL: https://issues.apache.org/jira/browse/BEAM-7470
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The intent is to remove the BeamFnApi.Target type since it is not used widely
> since it is intended that the remote reader/writer are identified uniquely by
> instruction id and transform id.
> We also remove the channel splits input id since it is unnecessary with this
> change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
