[
https://issues.apache.org/jira/browse/BEAM-7470?focusedWorklogId=252169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252169
]
ASF GitHub Bot logged work on BEAM-7470:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/19 00:57
Start Date: 01/Jun/19 00:57
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #8733: [BEAM-7470]
Update proto and all SDKs to make the logical data stream over the data plane
identified solely by instruction id and transform id.
URL: https://github.com/apache/beam/pull/8733#discussion_r289585534
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -520,18 +504,15 @@ message ProcessBundleSplitResponse {
// (Required) The grpc read transform reading this channel.
string ptransform_id = 1;
Review comment:
It pleases me that the code, the necessary semantics, and the documentation
all line up cleanly. I had a longer comment before that essentially derived the
semantics from the Go SDK side changes, partly because I missed this bit of
documentation earlier. (The excerpt included here is hidden above the fold)
// (Required) A definition representing a consumer or producer of this
data.
// If received by a harness, this represents the consumer within that
// harness that should consume these bytes. If sent by a harness, this
// represents the producer of these bytes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 252169)
Time Spent: 50m (was: 40m)
> Clean up Data Plane, rely only on instruction id and transform id
> -----------------------------------------------------------------
>
> Key: BEAM-7470
> URL: https://issues.apache.org/jira/browse/BEAM-7470
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The intent is to remove the BeamFnApi.Target type since it is not used widely
> since it is intended that the remote reader/writer are identified uniquely by
> instruction id and transform id.
> We also remove the channel splits input id since it is unnecessary with this
> change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
