[
https://issues.apache.org/jira/browse/BEAM-7407?focusedWorklogId=255535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255535
]
ASF GitHub Bot logged work on BEAM-7407:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 23:13
Start Date: 06/Jun/19 23:13
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #8745: [BEAM-7407]
Adds portable wordcount test for Python 3 with Flink runner.
URL: https://github.com/apache/beam/pull/8745#discussion_r291404227
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -87,7 +88,22 @@ def default_docker_image():
if 'USER' in os.environ:
# Perhaps also test if this was built?
logging.info('Using latest locally built Python SDK docker image.')
- return os.environ['USER'] +
'-docker-apache.bintray.io/beam/python:latest'
+ if sys.version_info[0] == 2:
+ version_suffix = ''
+ elif sys.version_info[0:2] == (3, 5):
+ version_suffix = '3'
+ else:
+ version_suffix = '3'
+ # TODO(BEAM-7474): Use an image which has correct Python minor version.
+ logging.warning('Make sure that locally built Python SDK docker image '
+ 'has Python %d.%d interpreter. See also: BEAM-7474.' %
(
+ sys.version_info[0], sys.version_info[1]))
+
+ return ('{user}-docker-apache.bintray.io/beam/python'
Review comment:
Shall we log the image URL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255535)
Time Spent: 1h 10m (was: 1h)
> Create a Wordcount-on-Flink Python 3 test suite.
> ------------------------------------------------
>
> Key: BEAM-7407
> URL: https://issues.apache.org/jira/browse/BEAM-7407
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Blocker
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
