[
https://issues.apache.org/jira/browse/BEAM-7407?focusedWorklogId=255565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255565
]
ASF GitHub Bot logged work on BEAM-7407:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/19 00:16
Start Date: 07/Jun/19 00:16
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #8745:
[BEAM-7407] Adds portable wordcount test for Python 3 with Flink runner.
URL: https://github.com/apache/beam/pull/8745#discussion_r291416627
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1815,6 +1815,58 @@ class BeamModulePlugin implements Plugin<Project> {
}
}
}
+
+ project.ext.addPortableWordCountTask = { String nameSuffix, boolean
isStreaming ->
Review comment:
I'm okay to have this task in `BeamModulePlugin` for now. But my concern is
that this may not be scalable if we want to add more variants (e.g. pipelines,
configurations) in the future. We probably can make it more configurable or put
it in separate groovy if more variants we are end up with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255565)
> Create a Wordcount-on-Flink Python 3 test suite.
> ------------------------------------------------
>
> Key: BEAM-7407
> URL: https://issues.apache.org/jira/browse/BEAM-7407
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Blocker
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
