[ 
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=259124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259124
 ]

ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/19 22:25
            Start Date: 12/Jun/19 22:25
    Worklog Time Spent: 10m 
      Work Description: steveniemitz commented on issue #7805: [BEAM-3061] Done 
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#issuecomment-501476973
 
 
   so thinking back a little more I realized something else.  While we have 
been focused on the `Wait.on` use case, we're also using the output of this to 
feed directly (via a `Sample.any`) into another DoFn.  If the bigtable DoFn 
didn't emit any elements, the DoFn after it would never be invoked.
   
   The topology looks something like:
   ```
   input
     .apply(BigtableIO.write(...)) //write some stuff
     .apply(Sample.any()) // wait for the window to close
     .apply(ParDo.of(new SomeDoFn())
   ```
   In order for SomeDoFn to actually be invoked, BigtableIO.write needs to emit 
(at least one) element.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 259124)
    Time Spent: 5h 50m  (was: 5h 40m)

> BigtableIO should support emitting a sentinel "done" value when a bundle 
> completes
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-3061
>                 URL: https://issues.apache.org/jira/browse/BEAM-3061
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Steve Niemitz
>            Assignee: Steve Niemitz
>            Priority: Major
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1].  This 
> approach was taken based on discussion there.
> [1] 
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to