[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=259207&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259207
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/19 01:11
Start Date: 13/Jun/19 01:11
Worklog Time Spent: 10m
Work Description: chamikaramj commented on issue #7805: [BEAM-3061] Done
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#issuecomment-501510492
> > How about just updating this recordsWritten counter to be per window and
outputting that ?
> >
https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java#L702
>
> Is this really any more useful than a `null`? I can't think of how anyone
would ever use the number for anything other than metrics (and there are other
ways to get it in that case).
>
I think number of records written probably combined with the spanner
instance ID might be a useful signal but I agree that this is debatable. For
example, this will allow us to compute the number of records written to each
spanner instance if we update SpannerIO to support dynamic destinations.
At least consider returning some sort of a metadata object instead of null
which will allow us to extend this functionality without breaking existing
pipelines.
> > Another option might be to output failed records. But this should be
optional since if everything get written to BigTable without errors, nothing
will get output from the write step.
>
> The way the IO is designed mutations never fail, either the whole batch
succeeds or it retries until it does (or the pipeline fails). ;)
Yeah, you are correct. So this is not an option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 259207)
Time Spent: 6h 20m (was: 6h 10m)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
