[
https://issues.apache.org/jira/browse/BEAM-7572?focusedWorklogId=263162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-263162
]
ASF GitHub Bot logged work on BEAM-7572:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/19 16:54
Start Date: 19/Jun/19 16:54
Worklog Time Spent: 10m
Work Description: lukecwik commented on issue #8891: [BEAM-7572]
ApproximateUnique.Globally and ApproximateUnique.PerKey classes are inaccessible
URL: https://github.com/apache/beam/pull/8891#issuecomment-503643189
Why do you want to make them public?
Even though they are inaccessible, you can still use the static methods like
globally/perKey to return an instance.
Also consider making the classes final so we don't have to worry about
backwards compatibility due to sub-classing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 263162)
Time Spent: 0.5h (was: 20m)
> ApproximateUnique.Globally and ApproximateUnique.PerKey classes are
> inaccessible
> --------------------------------------------------------------------------------
>
> Key: BEAM-7572
> URL: https://issues.apache.org/jira/browse/BEAM-7572
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.13.0
> Reporter: Gunnar Schulze
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The classes ApproximateUnique.Globally and ApproximateUnique.PerKey returned
> by ApproximateUnique.globally() and ApproximateUnique.perKey() are
> inaccessible because of a missing "public" modifier.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
