[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=264026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264026
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 19:03
Start Date: 20/Jun/19 19:03
Worklog Time Spent: 10m
Work Description: jkff commented on pull request #7805: [BEAM-3061] Done
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#discussion_r295951696
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -714,13 +719,18 @@ public void processElement(ProcessContext c) throws
Exception {
}
});
++recordsWritten;
+ seenWindows.add(window);
}
@FinishBundle
- public void finishBundle() throws Exception {
+ public void finishBundle(FinishBundleContext c) throws Exception {
bigtableWriter.flush();
checkForFailures();
LOG.debug("Wrote {} records", recordsWritten);
+
+ for (BoundedWindow window : seenWindows) {
+ c.output(BigtableWriteResult.create(recordsWritten),
window.maxTimestamp(), window);
Review comment:
I agree with @chamikaramj here: as-is, the returned value is kinda useless
because it can't be correctly aggregated - if we see 3 records in W1 and 5
records in W2 in a bundle, the current code will output (8, W1) and (8, W2)
with no way for a follow-up Sum to untangle them back. You don't need a GBK,
you just need a `HashMap<BoundedWindow, Integer>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264026)
Time Spent: 10h (was: 9h 50m)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 10h
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
