[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=264042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264042
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 19:08
Start Date: 20/Jun/19 19:08
Worklog Time Spent: 10m
Work Description: jkff commented on pull request #7805: [BEAM-3061] Done
notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#discussion_r295955006
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -714,13 +719,18 @@ public void processElement(ProcessContext c) throws
Exception {
}
});
++recordsWritten;
+ seenWindows.add(window);
}
@FinishBundle
- public void finishBundle() throws Exception {
+ public void finishBundle(FinishBundleContext c) throws Exception {
bigtableWriter.flush();
checkForFailures();
LOG.debug("Wrote {} records", recordsWritten);
+
+ for (BoundedWindow window : seenWindows) {
+ c.output(BigtableWriteResult.create(recordsWritten),
window.maxTimestamp(), window);
Review comment:
Not sure what's the issue with expiration here? Just clear the map at the
beginning of the bundle; you get 1 result per window per bundle.
However if you feel doubtful, then I'm also fine with removing
BigtableWriteResult and getting back to outputting null, but please make it a
`PCollection<?>` rather than `PCollection<Void>` so that later we can
reintroduce BigtableWriteResult without breaking compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264042)
Time Spent: 10h 40m (was: 10.5h)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
