[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=264177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264177
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 22:11
Start Date: 20/Jun/19 22:11
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8872: [BEAM-3645]
add ParallelBundleManager
URL: https://github.com/apache/beam/pull/8872#discussion_r296033268
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1444,9 +1485,12 @@ def _generate_splits_for_testing(self,
break
return split_results
- def process_bundle(self, inputs, expected_outputs):
+ def process_bundle(self, inputs, expected_outputs,
parallel_uid_counter=None):
# Unique id for the instruction processing this bundle.
- BundleManager._uid_counter += 1
+ if parallel_uid_counter:
Review comment:
Why this change. It seems we don't need to ever pass the uid counter in
externally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 264177)
Time Spent: 7h 40m (was: 7.5h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
