[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=264175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264175
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 22:11
Start Date: 20/Jun/19 22:11
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8872: [BEAM-3645]
add ParallelBundleManager
URL: https://github.com/apache/beam/pull/8872#discussion_r296032101
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -284,6 +322,8 @@ def run_pipeline(self, pipeline, options):
pipeline.visit(DataflowRunner.group_by_key_input_visitor())
self._bundle_repeat = self._bundle_repeat or options.view_as(
pipeline_options.DirectOptions).direct_runner_bundle_repeat
+ FnApiRunner._num_workers = max(FnApiRunner._num_workers, options.view_as(
Review comment:
Rather than max, it's probably better to have one take precedence.
Alternatively, only have one way to set this (e.g. via the option).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 264175)
Time Spent: 7h 20m (was: 7h 10m)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
