[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=266432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266432
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/19 08:33
Start Date: 25/Jun/19 08:33
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8872: [BEAM-3645]
add ParallelBundleManager
URL: https://github.com/apache/beam/pull/8872#discussion_r297050277
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -139,6 +139,18 @@ def done(self):
self._state = self.DONE_STATE
+class _ListBuffer(list):
+ """Used to support parititioning of a list."""
+ def partition(self, n):
+ n = min(n, len(self))
+ # for empty list, return iter([[]])
+ groups = [[] for _ in range(max(n, 1))]
+ for idx, input in enumerate(self):
+ groups[idx % n].append(input)
+
+ return iter(groups)
Review comment:
Just return groups here, not iter(groups).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 266432)
Time Spent: 10h 10m (was: 10h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
