[
https://issues.apache.org/jira/browse/BEAM-3645?focusedWorklogId=266443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266443
]
ASF GitHub Bot logged work on BEAM-3645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/19 08:33
Start Date: 25/Jun/19 08:33
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #8872: [BEAM-3645]
add ParallelBundleManager
URL: https://github.com/apache/beam/pull/8872#discussion_r297052915
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -165,9 +177,12 @@ def append(self, elements_data):
value if is_trivial_windowing
else windowed_key_value.with_value(value))
- def __iter__(self):
- if not self._grouped_output:
- output_stream = create_OutputStream()
+ def partition(self, n):
+ """ It is used to partition _GroupingBuffer to N parts. Once it is
+ partitioned, it would not be re-partitioned with diff N. Re-partition
+ is not supported now.
+ """
+ if len(self._grouped_output) == 0:
Review comment:
If not self._grouped_output
is slightly more pythonic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 266443)
Time Spent: 11h 40m (was: 11.5h)
> Support multi-process execution on the FnApiRunner
> --------------------------------------------------
>
> Key: BEAM-3645
> URL: https://issues.apache.org/jira/browse/BEAM-3645
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Charles Chen
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-3644 gave us a 15x performance
> gain over the previous DirectRunner. We can do even better in multi-core
> environments by supporting multi-process execution in the FnApiRunner, to
> scale past Python GIL limitations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
