[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=267430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267430
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 09:51
Start Date: 26/Jun/19 09:51
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7805: [BEAM-3061]
Done notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#discussion_r297578144
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -131,6 +134,32 @@
* .withTableId("table"));
* }</pre>
*
+ * <p>Optionally, BigtableIO.write() may be configured to emit {@link
BigtableWriteResult} elements
+ * after each group of inputs is written to Bigtable. These can be used to
then trigger user code
+ * after writes have completed, for example:
+ *
+ * <pre>{@code
+ * // Note, data must have a windowing function set to something other than
the global window.
Review comment:
Mmm actually after looking at the [Wait
javadoc](https://github.com/iemejia/beam/blob/1ad61fd384bcd1edd11086a3cf9d7dddb154d934/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Wait.java#L68)
I have the impression the global window is covered too but it requires the
input to be bounded. So maybe this comment is not needed.
`If signal is globally windowed, main input must also be. This typically
would be useful only in a batch pipeline, because the global window of an
infinite PCollection never closes, so the wait signal will never be ready. `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 267430)
Time Spent: 13h 40m (was: 13.5h)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
