[
https://issues.apache.org/jira/browse/BEAM-3061?focusedWorklogId=267642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267642
]
ASF GitHub Bot logged work on BEAM-3061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 13:45
Start Date: 26/Jun/19 13:45
Worklog Time Spent: 10m
Work Description: steveniemitz commented on pull request #7805:
[BEAM-3061] Done notifications for BigtableIO.Write
URL: https://github.com/apache/beam/pull/7805#discussion_r297673778
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
##########
@@ -131,6 +134,32 @@
* .withTableId("table"));
* }</pre>
*
+ * <p>Optionally, BigtableIO.write() may be configured to emit {@link
BigtableWriteResult} elements
+ * after each group of inputs is written to Bigtable. These can be used to
then trigger user code
+ * after writes have completed, for example:
+ *
+ * <pre>{@code
+ * // Note, data must have a windowing function set to something other than
the global window.
Review comment:
oh yeah, this works for batch...we even use it in batch mode already. I'm
not sure why I added that comment. I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 267642)
Time Spent: 14h 10m (was: 14h)
> BigtableIO should support emitting a sentinel "done" value when a bundle
> completes
> ----------------------------------------------------------------------------------
>
> Key: BEAM-3061
> URL: https://issues.apache.org/jira/browse/BEAM-3061
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: Major
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> There was some discussion of this on the dev@ mailing list [1]. This
> approach was taken based on discussion there.
> [1]
> https://lists.apache.org/thread.html/949b33782f722a9000c9bf9e37042739c6fd0927589b99752b78d7bd@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
