[ 
https://issues.apache.org/jira/browse/BEAM-7534?focusedWorklogId=270484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270484
 ]

ASF GitHub Bot logged work on BEAM-7534:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/19 21:32
            Start Date: 01/Jul/19 21:32
    Worklog Time Spent: 10m 
      Work Description: ihji commented on pull request #8828: [BEAM-7534] add 
--mountTempDir option for Docker container
URL: https://github.com/apache/beam/pull/8828#discussion_r299225765
 
 

 ##########
 File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/options/ManualDockerEnvironmentOptions.java
 ##########
 @@ -32,6 +32,14 @@
 
   void setRetainDockerContainers(boolean retainDockerContainers);
 
+  @Description(
+      "Mount temporary directory to Docker container instance. "
+          + "The parameter is a path relative to the system temporary 
directory "
+          + "e.g. '--mountTempDir foo' implies '/tmp/foo' on Linux.")
+  String getMountTempDir();
 
 Review comment:
   We can put a unique prefix for helping avoid possible conflict but I think 
still a rule of thumb is that users need to be cautious in choosing mounting 
directory name. In case of this new option, the base directory is fixed to /tmp 
so conflicts might not easily happen.
   
   For multiple mount dirs, I'm not sure how much it's useful since users can 
create as many directories as they want in a single mounting directory.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 270484)
    Time Spent: 2h 40m  (was: 2.5h)

> add --mountTempDir option for easier data sharing with Docker container
> -----------------------------------------------------------------------
>
>                 Key: BEAM-7534
>                 URL: https://issues.apache.org/jira/browse/BEAM-7534
>             Project: Beam
>          Issue Type: Improvement
>          Components: java-fn-execution
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: Major
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> add --mountTempDir option for easier data sharing with Docker container.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to