[
https://issues.apache.org/jira/browse/BEAM-7534?focusedWorklogId=276304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276304
]
ASF GitHub Bot logged work on BEAM-7534:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/19 15:36
Start Date: 13/Jul/19 15:36
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8828: [BEAM-7534] add
--mountTempDir option for Docker container
URL: https://github.com/apache/beam/pull/8828#discussion_r303209328
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsReflector.java
##########
@@ -36,7 +36,8 @@ private PipelineOptionsReflector() {}
*
* @see PipelineOptionsReflector#getOptionSpecs(Iterable)
*/
- static Set<PipelineOptionSpec> getOptionSpecs(Class<? extends
PipelineOptions> optionsInterface) {
+ static Set<PipelineOptionSpec> getOptionSpecs(
+ Class<? extends PipelineOptions> optionsInterface, boolean skipHidden) {
Review comment:
This introduces a new feature: hidden options. I'm not sure about the
consequences of such a feature. I believe such options would be better stored
in the docker environment config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276304)
Time Spent: 3h 20m (was: 3h 10m)
> add --mountTempDir option for easier data sharing with Docker container
> -----------------------------------------------------------------------
>
> Key: BEAM-7534
> URL: https://issues.apache.org/jira/browse/BEAM-7534
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> add --mountTempDir option for easier data sharing with Docker container.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
