[
https://issues.apache.org/jira/browse/BEAM-4420?focusedWorklogId=271614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271614
]
ASF GitHub Bot logged work on BEAM-4420:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/19 12:54
Start Date: 03/Jul/19 12:54
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #8986: [BEAM-4420] Add
KafkaIO Integration Tests
URL: https://github.com/apache/beam/pull/8986#issuecomment-508080567
@iemejia @aromanenko-dev thanks for the review. I provided fixes.
@iemejia I didn't squash the commits on purpose - those are two atomic,
independent changes. Having them as separate commits shows better why exactly
something changed with proper commit titles and descriptions (see the
description for the Kubernetes change). Squash will obfuscate this and will
result with multiple unrelated changes in one commit. Other than that it will
be easier to revert parts if needed. Suppose I was to revert only the
Kubernetes change. Should I be forced to revert the whole test too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 271614)
Time Spent: 1h 40m (was: 1.5h)
> Add KafkaIO Integration Tests
> -----------------------------
>
> Key: BEAM-4420
> URL: https://issues.apache.org/jira/browse/BEAM-4420
> Project: Beam
> Issue Type: Test
> Components: io-java-kafka, testing
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It is a good idea to have ITs for KafkaIO.
> There are two possible issues:
> 1. The tests should probably invert the pattern to be readThenWrite given
> that Unbounded IOs block on Read and ...
> 2. Until we have a way to do PAsserts on Unbounded sources we can rely on
> withMaxNumRecords to ensure this test ends.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
