[
https://issues.apache.org/jira/browse/BEAM-4420?focusedWorklogId=278172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278172
]
ASF GitHub Bot logged work on BEAM-4420:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 11:42
Start Date: 17/Jul/19 11:42
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #9073: [BEAM-4420] KafkaIOIT
metrics collection
URL: https://github.com/apache/beam/pull/9073#issuecomment-512218500
Thanks! I posted the fixes. Could you take a look again?
I also squashed the Kafka part but left out the IOITMetrics refactoring as a
separate commit. I think it's a separate concern, more general one that we
didn't have a way to publish already collected `NamedTestResult`s. For order
and clean git history, I'd like to keep it separate unless you have something
against.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278172)
Time Spent: 3h 10m (was: 3h)
> Add KafkaIO Integration Tests
> -----------------------------
>
> Key: BEAM-4420
> URL: https://issues.apache.org/jira/browse/BEAM-4420
> Project: Beam
> Issue Type: Test
> Components: io-java-kafka, testing
> Reporter: Ismaël Mejía
> Assignee: Lukasz Gajowy
> Priority: Minor
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> It is a good idea to have ITs for KafkaIO.
> There are two possible issues:
> 1. The tests should probably invert the pattern to be readThenWrite given
> that Unbounded IOs block on Read and ...
> 2. Until we have a way to do PAsserts on Unbounded sources we can rely on
> withMaxNumRecords to ensure this test ends.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
