[
https://issues.apache.org/jira/browse/BEAM-7420?focusedWorklogId=272150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272150
]
ASF GitHub Bot logged work on BEAM-7420:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/19 11:34
Start Date: 04/Jul/19 11:34
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8894: [BEAM-7420]: Allow
including the flink runner without flink on the classpath.
URL: https://github.com/apache/beam/pull/8894#discussion_r300358988
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkPipelineOptionsTest.java
##########
@@ -77,7 +75,7 @@ public void testDefaults() {
assertThat(options.getLatencyTrackingInterval(), is(0L));
assertThat(options.isShutdownSourcesOnFinalWatermark(), is(false));
assertThat(options.getObjectReuse(), is(false));
- assertThat(options.getCheckpointingMode(),
is(CheckpointingMode.EXACTLY_ONCE));
+ assertThat(options.getCheckpointingMode(), is("EXACTLY_ONCE"));
Review comment:
```suggestion
assertThat(options.getCheckpointingMode(),
is(CheckpointingMode.EXACTLY_ONCE.name()));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 272150)
Time Spent: 40m (was: 0.5h)
> Including the Flink runner causes exceptions unless running in a flink
> environment
> ----------------------------------------------------------------------------------
>
> Key: BEAM-7420
> URL: https://issues.apache.org/jira/browse/BEAM-7420
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Mike Kaplinskiy
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{FlinkPipelineOptions}} imports various Flink enums which make it
> impossible to e.g. run the direct runner with the same classpath but without
> the flink runtime. The fix is potentially easy - make the arguments strings
> and convert them to enums at the callsites.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
