[
https://issues.apache.org/jira/browse/BEAM-7420?focusedWorklogId=272399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272399
]
ASF GitHub Bot logged work on BEAM-7420:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/19 02:17
Start Date: 05/Jul/19 02:17
Worklog Time Spent: 10m
Work Description: mikekap commented on pull request #8894: [BEAM-7420]:
Allow including the flink runner without flink on the classpath.
URL: https://github.com/apache/beam/pull/8894#discussion_r300523080
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineOptions.java
##########
@@ -146,11 +149,12 @@
*/
@Description(
"Sets the state backend to use in streaming mode. "
- + "Otherwise the default is read from the Flink config.")
+ + "Otherwise the default is read from the Flink config. "
+ + "This should be an instance of {@link
org.apache.flink.runtime.state.StateBackend}")
@JsonIgnore
- StateBackend getStateBackend();
+ Object getStateBackend();
- void setStateBackend(StateBackend stateBackend);
+ void setStateBackend(Object stateBackend);
Review comment:
I tried to do this, but I didn't quite know how to let folks configure the
backend nicely. The backends in flink have different constructor arguments
which makes something generic...a little difficult. The factory gets the
options object, so presumably it can be somewhat dynamic. Let me know if you
were thinking of something different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 272399)
Time Spent: 50m (was: 40m)
> Including the Flink runner causes exceptions unless running in a flink
> environment
> ----------------------------------------------------------------------------------
>
> Key: BEAM-7420
> URL: https://issues.apache.org/jira/browse/BEAM-7420
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Mike Kaplinskiy
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The {{FlinkPipelineOptions}} imports various Flink enums which make it
> impossible to e.g. run the direct runner with the same classpath but without
> the flink runtime. The fix is potentially easy - make the arguments strings
> and convert them to enums at the callsites.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
