[
https://issues.apache.org/jira/browse/BEAM-5440?focusedWorklogId=273679&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273679
]
ASF GitHub Bot logged work on BEAM-5440:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 03:43
Start Date: 09/Jul/19 03:43
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #8982: [BEAM-5440] Pass
docker run options to SDK harness containers
URL: https://github.com/apache/beam/pull/8982#issuecomment-509475091
I think we are going to want to do this in a backward compatible way. Any
suggestions?
On Mon, Jul 8, 2019 at 11:39 PM Sam Bourne <[email protected]> wrote:
> *@sambvfx* commented on this pull request.
> ------------------------------
>
> In
>
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/DockerEnvironmentFactory.java
> <https://github.com/apache/beam/pull/8982#discussion_r301384620>:
>
> > @@ -136,6 +138,10 @@ public RemoteEnvironment
createEnvironment(Environment environment) throws Excep
> dockerArgsBuilder.add("--rm");
> }
>
> + if (!dockerOptions.isEmpty()) {
> +
dockerArgsBuilder.addAll(Arrays.asList(dockerOptions.split("\\s+")));
>
> I'm happy with your proposed change as it mirrors the DockerPayload
> proto. I was confused because this json request was attached to the java
> code, but this would only exist within the SDK before we unpack it into the
> protobuf.
>
> It's worth noting the downsides of this would be:
>
> - backwards incompatible
> - difficult to provide json as an argparse argument (within the SDK)
>
> Both are inconsequential to me.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/8982?email_source=notifications&email_token=AAAPOEYBSFDEYHB6M76ATH3P6QCANA5CNFSM4H4XWDM2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5Z6W2Y#discussion_r301384620>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AAAPOEYCT75VR2QKCYF2CSDP6QCANANCNFSM4H4XWDMQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 273679)
Time Spent: 2h (was: 1h 50m)
> Add option to mount a directory inside SDK harness containers
> -------------------------------------------------------------
>
> Key: BEAM-5440
> URL: https://issues.apache.org/jira/browse/BEAM-5440
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution, sdk-java-core
> Reporter: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 2h
> Remaining Estimate: 0h
>
> While experimenting with the Python SDK locally, I found it inconvenient that
> I can't mount a host directory to the Docker containers, i.e. the input must
> already be in the container and the results of a Write remain inside the
> container. For local testing, users may want to mount a host directory.
> Since BEAM-5288 the {{Environment}} carries explicit environment information,
> we could a) add volume args to the {{DockerPayload}}, or b) provide a general
> Docker arguments field.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
