[
https://issues.apache.org/jira/browse/BEAM-7696?focusedWorklogId=277073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277073
]
ASF GitHub Bot logged work on BEAM-7696:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 23:55
Start Date: 15/Jul/19 23:55
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #9019: [BEAM-7696]
Prepare files to stage also in local master of spark runner.
URL: https://github.com/apache/beam/pull/9019#discussion_r303678227
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PipelineResources.java
##########
@@ -61,7 +61,10 @@
List<String> files = new ArrayList<>();
for (URL url : ((URLClassLoader) classLoader).getURLs()) {
try {
- files.add(new File(url.toURI()).getAbsolutePath());
+ File file = new File(url.toURI());
+ if (file.exists()) {
Review comment:
Since SparkContext will reject all directories [1], it is probably best to
exclude directories too.
```suggestion
if (file.exists() && !file.isDirectory()) {
```
[1]
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L1796-L1802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 277073)
Time Spent: 1h 40m (was: 1.5h)
> Detect classpath resources contains directory cause exception
> -------------------------------------------------------------
>
> Key: BEAM-7696
> URL: https://issues.apache.org/jira/browse/BEAM-7696
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Wang Yanlin
> Assignee: Wang Yanlin
> Priority: Minor
> Fix For: 2.15.0
>
> Attachments: addJar_exception.jpg, files_contains_dir.jpg
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Run the unit test SparkPipelineStateTest.testBatchPipelineRunningState in
> IntelliJ IDEA on my mac, get the IllegalArgumentException in the console
> output. I check the source code, and find the result of
> _PipelineResources.detectClassPathResourcesToStage_ contains directory, which
> is the cause of the exception.
> See the attached file 'addJar_exception.jpg' for detail, and the result of
> _PipelineResources.detectClassPathResourcesToStage_
> is showed in attached file 'files_contains_dir.jpg' during debug.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
