[
https://issues.apache.org/jira/browse/BEAM-7696?focusedWorklogId=280202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280202
]
ASF GitHub Bot logged work on BEAM-7696:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/19 02:40
Start Date: 22/Jul/19 02:40
Worklog Time Spent: 10m
Work Description: yanlin-Lynn commented on issue #9019: [BEAM-7696]
Prepare files to stage also in local master of spark runner.
URL: https://github.com/apache/beam/pull/9019#issuecomment-512740623
> Hi Yanlin, thanks for the PR.
>
> Since `PipelineResources.java` is in the `core-construction` package, it
is shared by all Beam runners. While adding directories just causes Spark to
throw an exception, directories might be acceptable or even desirable on
different runners (I don't actually know--just being cautious here). So it
would be better to limit this change to the `runners.spark` package (maybe by
calling `PipelineResources.detectClassPathResourcesToStage` as-is, then
removing directories in `SparkPipelineOptions.prepareFilesToStage`).
Yeah. I aggre with you. And in this patch, I do exclude directories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 280202)
Time Spent: 2h 50m (was: 2h 40m)
> Detect classpath resources contains directory cause exception
> -------------------------------------------------------------
>
> Key: BEAM-7696
> URL: https://issues.apache.org/jira/browse/BEAM-7696
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Wang Yanlin
> Assignee: Wang Yanlin
> Priority: Minor
> Fix For: 2.15.0
>
> Attachments: addJar_exception.jpg, files_contains_dir.jpg
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Run the unit test SparkPipelineStateTest.testBatchPipelineRunningState in
> IntelliJ IDEA on my mac, get the IllegalArgumentException in the console
> output. I check the source code, and find the result of
> _PipelineResources.detectClassPathResourcesToStage_ contains directory, which
> is the cause of the exception.
> See the attached file 'addJar_exception.jpg' for detail, and the result of
> _PipelineResources.detectClassPathResourcesToStage_
> is showed in attached file 'files_contains_dir.jpg' during debug.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
