[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=278385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278385
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 18:24
Start Date: 17/Jul/19 18:24
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9056: [BEAM-7746] Add
python type hints
URL: https://github.com/apache/beam/pull/9056#discussion_r304569350
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -193,7 +200,7 @@ def __repr__(self):
self.input_types, self.output_types)
-class WithTypeHints(object):
+class WithTypeHints(Generic[InT, OutT]):
Review comment:
I'm afraid that if we add a second typing system here will create confusion.
If I write a PTransform, do I specify an input type to Generic[] or do I use a
@with_input_type decorator? Which one is enforced?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278385)
Time Spent: 1.5h (was: 1h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
