[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=278433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278433
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/19 19:42
Start Date: 17/Jul/19 19:42
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #9056: [BEAM-7746]
Add python type hints
URL: https://github.com/apache/beam/pull/9056#discussion_r304608935
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -100,13 +101,19 @@ def foo((a, b)):
from apache_beam.typehints.typehints import check_constraint
from apache_beam.typehints.typehints import validate_composite_type_param
+from typing import Any, Callable, Generic, TypeVar
+
__all__ = [
'with_input_types',
'with_output_types',
'WithTypeHints',
'TypeCheckError',
]
+InT = TypeVar('InT')
+OutT = TypeVar('OutT')
+WithTypeHintsT = TypeVar('WithTypeHintsT', bound='WithTypeHints')
Review comment:
practically speaking, this is less about enforcing correctness (as in "make
sure that a user always passes a `WithTypeHints` instance"), and more about
avoiding errors due to mypy not knowing what type it's dealing with (e.g.
trying to access a method will error unless mypy is aware that the object is a
`WithTypeHints` instance).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 278433)
Time Spent: 2h 50m (was: 2h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
