[
https://issues.apache.org/jira/browse/BEAM-7495?focusedWorklogId=281157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-281157
]
ASF GitHub Bot logged work on BEAM-7495:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/19 17:18
Start Date: 23/Jul/19 17:18
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #9079:
[BEAM-7495] Add progress reporting to the BigQuery source
URL: https://github.com/apache/beam/pull/9079#discussion_r306437153
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -201,15 +206,20 @@ public synchronized boolean advance() throws IOException
{
private synchronized boolean readNextRecord() throws IOException {
while (decoder == null || decoder.isEnd()) {
if (!responseIterator.hasNext()) {
+ fractionConsumed = 1d;
return false;
}
+ // N.B.: For simplicity, we update fractionConsumed once a new
response is fetched, not
+ // when we reach the end of the current response. In practice, this
choice is not
+ // consequential.
+ fractionConsumed = fractionConsumedFromLastResponse;
Review comment:
Thanks for clarifying. Current implementation (that updates the progress for
a record in the advance() call following the getCurrent() call that returns the
record) seems to be correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 281157)
Time Spent: 5h 10m (was: 5h)
Remaining Estimate: 498h 50m (was: 499h)
> Add support for dynamic worker re-balancing when reading BigQuery data using
> Cloud Dataflow
> -------------------------------------------------------------------------------------------
>
> Key: BEAM-7495
> URL: https://issues.apache.org/jira/browse/BEAM-7495
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Aryan Naraghi
> Assignee: Aryan Naraghi
> Priority: Major
> Original Estimate: 504h
> Time Spent: 5h 10m
> Remaining Estimate: 498h 50m
>
> Currently, the BigQuery connector for reading data using the BigQuery Storage
> API does not support any of the facilities on the source for Dataflow to
> split streams.
>
> On the server side, the BigQuery Storage API supports splitting streams at a
> fraction. By adding support to the connector, we enable Dataflow to split
> streams, which unlocks dynamic worker re-balancing.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
