[
https://issues.apache.org/jira/browse/BEAM-7828?focusedWorklogId=286275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286275
]
ASF GitHub Bot logged work on BEAM-7828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/19 23:15
Start Date: 31/Jul/19 23:15
Worklog Time Spent: 10m
Work Description: udim commented on pull request #9174: [BEAM-7828] Fixes
Key type conversion from/to client entity in Python Datastore IO
URL: https://github.com/apache/beam/pull/9174#discussion_r309467661
##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
##########
@@ -382,6 +382,8 @@ def add_element_to_batch(self, element):
if not isinstance(element, types.Entity):
raise
ValueError('apache_beam.io.gcp.datastore.v1new.datastoreio.Entity'
' expected, got: %s' % type(element))
+ if not element.key.project:
Review comment:
I can't comment there, but could you add to the comment on line 368 that
missing project values will be filled with the transform's value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 286275)
Time Spent: 50m (was: 40m)
> Add key type conversion in from and to client entity in Datastore v1new IO.
> ---------------------------------------------------------------------------
>
> Key: BEAM-7828
> URL: https://issues.apache.org/jira/browse/BEAM-7828
> Project: Beam
> Issue Type: Sub-task
> Components: io-python-gcp
> Reporter: Valentyn Tymofieiev
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
