[
https://issues.apache.org/jira/browse/BEAM-7828?focusedWorklogId=286887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286887
]
ASF GitHub Bot logged work on BEAM-7828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/19 17:37
Start Date: 01/Aug/19 17:37
Worklog Time Spent: 10m
Work Description: post-l commented on issue #9174: [BEAM-7828] Fixes Key
type conversion from/to client entity in Python Datastore IO
URL: https://github.com/apache/beam/pull/9174#issuecomment-517386708
After adding the class comments, I realized that we could go with removing
the project attribute from the `Key` class. `WriteToDatastore` and
`DeleteFromDatastore` would pass the transform's project value to the
`to_client_entity` method on `Entity` and `Key`.
This would ease reading from a project and writing to another (removing the
need to add a transform step to remove or update the project fields on the
keys).
I guess this could be discuss in a new issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 286887)
Time Spent: 1.5h (was: 1h 20m)
> Add key type conversion in from and to client entity in Datastore v1new IO.
> ---------------------------------------------------------------------------
>
> Key: BEAM-7828
> URL: https://issues.apache.org/jira/browse/BEAM-7828
> Project: Beam
> Issue Type: Sub-task
> Components: io-python-gcp
> Reporter: Valentyn Tymofieiev
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
