[
https://issues.apache.org/jira/browse/BEAM-7832?focusedWorklogId=286984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286984
]
ASF GitHub Bot logged work on BEAM-7832:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/19 19:50
Start Date: 01/Aug/19 19:50
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9210: [BEAM-7832]
Add ZetaSQL as a dialect in BeamSQL
URL: https://github.com/apache/beam/pull/9210#discussion_r309868511
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java
##########
@@ -309,6 +312,10 @@ private QueryPlanner instantiatePlanner(JdbcConnection
jdbcConnection, RuleSet[]
return new CalciteQueryPlanner(jdbcConnection, ruleSets);
}
+ if (queryPlannerClassName.equals(ZETASQL_PLANNER)) {
Review comment:
Replace this with a reflection version and move it into its own PR:
```
try {
return Class.forName(queryPlannerClassName)
.getConstructor(QueryPlanner.class)
.newInstance(jdbcConnection, ruleSets);
} catch (Exception e) {
throw new RuntimeException(
String.format("Cannot construct query planner %s",
queryPlannerClassName), e);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 286984)
Time Spent: 1h 50m (was: 1h 40m)
> ZetaSQL Dialect
> ---------------
>
> Key: BEAM-7832
> URL: https://issues.apache.org/jira/browse/BEAM-7832
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We can support ZetaSQL(https://github.com/google/zetasql) dialect in BeamSQL.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
