[
https://issues.apache.org/jira/browse/BEAM-7832?focusedWorklogId=287463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-287463
]
ASF GitHub Bot logged work on BEAM-7832:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/19 03:59
Start Date: 02/Aug/19 03:59
Worklog Time Spent: 10m
Work Description: amaliujia commented on issue #9210: [BEAM-7832] Add
ZetaSQL as a dialect in BeamSQL
URL: https://github.com/apache/beam/pull/9210#issuecomment-517538851
@apilloud
During moving ZetaSQL planner to another package, I find a dependency
problem: Calcite.
BeamSQL depends on Calcite and does relocation on it.
ZetaSQL planner also depends on Calcite.
The problem is, in order to initialize an instance of ZetaSQL planner, we
expect BeamSQL pass in a config to ZetaSQL planner, which unfortunately is
[CalciteConnectionConfig](https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/config/CalciteConnectionConfig.java).
Clearly, it causes a conflict and code fails to compile.
The right solution is vendored Calcite, which is in progress:
https://github.com/apache/beam/pull/9189
So I suggest we still keep all code BeamSQL, but in the dedicated `zetasql`
directory. Once vendored Calcite effort is done, we can move ZetaSQL code to a
separate module.
What do you think? Do you have a better idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 287463)
Time Spent: 2h 10m (was: 2h)
> ZetaSQL Dialect
> ---------------
>
> Key: BEAM-7832
> URL: https://issues.apache.org/jira/browse/BEAM-7832
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> We can support ZetaSQL(https://github.com/google/zetasql) dialect in BeamSQL.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
