[
https://issues.apache.org/jira/browse/BEAM-3342?focusedWorklogId=289297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289297
]
ASF GitHub Bot logged work on BEAM-3342:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/19 01:06
Start Date: 06/Aug/19 01:06
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #8457: [BEAM-3342]
Create a Cloud Bigtable IO connector for Python
URL: https://github.com/apache/beam/pull/8457#discussion_r310839096
##########
File path: sdks/python/apache_beam/io/gcp/bigtableio.py
##########
@@ -122,22 +129,148 @@ class WriteToBigTable(beam.PTransform):
A PTransform that write a list of `DirectRow` into the Bigtable Table
"""
- def __init__(self, project_id=None, instance_id=None,
- table_id=None):
+ def __init__(self, project_id=None, instance_id=None, table_id=None):
""" The PTransform to access the Bigtable Write connector
Args:
project_id(str): GCP Project of to write the Rows
instance_id(str): GCP Instance to write the Rows
table_id(str): GCP Table to write the `DirectRows`
"""
super(WriteToBigTable, self).__init__()
- self.beam_options = {'project_id': project_id,
+ self._beam_options = {'project_id': project_id,
'instance_id': instance_id,
'table_id': table_id}
def expand(self, pvalue):
- beam_options = self.beam_options
+ beam_options = self._beam_options
return (pvalue
| beam.ParDo(_BigTableWriteFn(beam_options['project_id'],
beam_options['instance_id'],
beam_options['table_id'])))
+
+
+class _BigtableReadFn(beam.DoFn):
+ """ Creates the connector that can read rows for Beam pipeline
+
+ Args:
+ project_id(str): GCP Project ID
+ instance_id(str): GCP Instance ID
+ table_id(str): GCP Table ID
+
+ """
+
+ def __init__(self, project_id, instance_id, table_id, start_key=None,
end_key=None, filter_=b''):
Review comment:
For this DoFn, the `start_key`, and `end_key` are not known at `__init__`
time (or for that matter, neither at pickling/unpickling time). The start_key,
and end_key are provided by the element coming from the upstream transform.
I'd recommend removing start_key, end_key from the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 289297)
Time Spent: 29.5h (was: 29h 20m)
> Create a Cloud Bigtable IO connector for Python
> -----------------------------------------------
>
> Key: BEAM-3342
> URL: https://issues.apache.org/jira/browse/BEAM-3342
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Priority: Major
> Time Spent: 29.5h
> Remaining Estimate: 0h
>
> I would like to create a Cloud Bigtable python connector.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
