[
https://issues.apache.org/jira/browse/BEAM-7916?focusedWorklogId=290441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290441
]
ASF GitHub Bot logged work on BEAM-7916:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 12:44
Start Date: 07/Aug/19 12:44
Worklog Time Spent: 10m
Work Description: RyanSkraba commented on issue #9285: [BEAM-7916] -
Change ElasticsearchIO query parameter to be a ValueProvider
URL: https://github.com/apache/beam/pull/9285#issuecomment-519080014
For info: @jbonofre and @echauchot are not available this week, you might
want to find an alternate reviewer.
For what it's worth, LGTM but I would highly recommend the suggested change
for compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290441)
Time Spent: 20m (was: 10m)
> Change ElasticsearchIO query parameter to be a ValueProvider
> ------------------------------------------------------------
>
> Key: BEAM-7916
> URL: https://issues.apache.org/jira/browse/BEAM-7916
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Affects Versions: 2.14.0
> Reporter: Oliver Henlich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We need to be able to perform Elasticsearch queries that are dynamic. The
> problem is {{ElasticsearchIO.read().withQuery()}} only accepts a string which
> means the query must be known when the pipleline/Google Dataflow Template is
> built.
> It would be great if we could change the parameter on the {{withQuery()}}
> method from {{String}} to {{ValueProvider<String>}}.
> Pull request: https://github.com/apache/beam/pull/9285
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)