[
https://issues.apache.org/jira/browse/BEAM-7916?focusedWorklogId=290812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290812
]
ASF GitHub Bot logged work on BEAM-7916:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 22:16
Start Date: 07/Aug/19 22:16
Worklog Time Spent: 10m
Work Description: oliverhenlich commented on pull request #9285:
[BEAM-7916] - Change ElasticsearchIO query parameter to be a ValueProvider
URL: https://github.com/apache/beam/pull/9285#discussion_r311786159
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -499,9 +500,8 @@ public Read
withConnectionConfiguration(ConnectionConfiguration connectionConfig
* DSL</a>
* @return a {@link PTransform} reading data from Elasticsearch.
*/
- public Read withQuery(String query) {
+ public Read withQuery(ValueProvider<String> query) {
Review comment:
Hi @RyanSkraba.
Thanks for taking a look. Yes I should have done as you suggested in the
first place to avoid peoples code breaking because of my change. Pushed my
changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290812)
Time Spent: 0.5h (was: 20m)
> Change ElasticsearchIO query parameter to be a ValueProvider
> ------------------------------------------------------------
>
> Key: BEAM-7916
> URL: https://issues.apache.org/jira/browse/BEAM-7916
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Affects Versions: 2.14.0
> Reporter: Oliver Henlich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We need to be able to perform Elasticsearch queries that are dynamic. The
> problem is {{ElasticsearchIO.read().withQuery()}} only accepts a string which
> means the query must be known when the pipleline/Google Dataflow Template is
> built.
> It would be great if we could change the parameter on the {{withQuery()}}
> method from {{String}} to {{ValueProvider<String>}}.
> Pull request: https://github.com/apache/beam/pull/9285
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
