[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=290894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290894
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/19 00:09
Start Date: 08/Aug/19 00:09
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9188: [BEAM-7886]
Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r311292446
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CoderTranslationTest.java
##########
@@ -74,6 +78,14 @@
FullWindowedValueCoder.of(
IterableCoder.of(VarLongCoder.of()),
IntervalWindowCoder.of()))
.add(DoubleCoder.of())
+ .add(
Review comment:
It seems that the tests here won't be able to compare `RowCoder`'s equality
properly. The root of the problem is not in this file though. It is because
`RowCoder` currently does not define a correct `equals()` method (any two
`RowCoder` instances are considered equal now).
Details: `RowCoder` currently extends `StructuredCoder`'s `equals()`
definition, which checks if the `component`s in the coder are the same, but the
schema associated with a `RowCoder` is not its `component`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290894)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
