[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=290891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290891
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/19 00:09
Start Date: 08/Aug/19 00:09
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9188: [BEAM-7886]
Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r311196553
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -642,6 +642,45 @@ message StandardCoders {
// Components: Coder for a single element.
// Experimental.
STATE_BACKED_ITERABLE = 9 [(beam_urn) =
"beam:coder:state_backed_iterable:v1"];
+
+ // Additional Standard Coders
+ // --------------------------
+ // The following coders are not required to be implemented for an SDK or
+ // runner to support the Beam model, but can enable additional
+ // functionality.
+
+ // Encodes a "row", an element with a known schema, defined by an
+ // instance of Schema from schema.proto.
+ //
+ // A row is encoded as the concatenation of:
+ // - The number of attributes in the schema, encoded with
+ // beam:coder:varint:v1. This is useful for detecting supported schema
+ // changes (column additions/deletions).
+ // - A packed bitset indicating null fields (a 1 indicating a null)
+ // encoded with beam:coder:bytes:v1. If there are no nulls an empty
byte
+ // array is encoded.
+ // - An encoding for each non-null field, concatenated together.
+ //
+ // Schema types are mapped to coders as follows:
+ // AtomicType:
+ // BYTE: not yet a standard coder
Review comment:
Maybe add a JIRA ticket link here saying we do need to close these gaps
before making row coder truly standard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 290891)
Time Spent: 1h 10m (was: 1h)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
