[
https://issues.apache.org/jira/browse/BEAM-7389?focusedWorklogId=292247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292247
]
ASF GitHub Bot logged work on BEAM-7389:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 21:09
Start Date: 09/Aug/19 21:09
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9257: [BEAM-7389] Add
DoFn methods sample
URL: https://github.com/apache/beam/pull/9257#discussion_r310835340
##########
File path:
sdks/python/apache_beam/examples/snippets/transforms/element_wise/pardo.py
##########
@@ -81,3 +82,44 @@ def process(self, elem, timestamp=beam.DoFn.TimestampParam,
window=beam.DoFn.Win
# pylint: enable=line-too-long
if test:
test(dofn_params)
+
+
+def pardo_dofn_methods(test=None):
+ # [START pardo_dofn_methods]
+ import apache_beam as beam
+
+ class DoFnMethods(beam.DoFn):
+ def __init__(self):
+ print('__init__')
+ self.window = beam.window.GlobalWindow()
+
+ def setup(self):
+ print('setup')
Review comment:
Add comments to these method explaining when are they called, are they
required, and what are they supposed to do, and how they are helpful for users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 292247)
Time Spent: 39h 10m (was: 39h)
> Colab examples for element-wise transforms (Python)
> ---------------------------------------------------
>
> Key: BEAM-7389
> URL: https://issues.apache.org/jira/browse/BEAM-7389
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Rose Nguyen
> Assignee: David Cavazos
> Priority: Minor
> Time Spent: 39h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
