[
https://issues.apache.org/jira/browse/BEAM-7389?focusedWorklogId=292246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292246
]
ASF GitHub Bot logged work on BEAM-7389:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 21:09
Start Date: 09/Aug/19 21:09
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9257: [BEAM-7389] Add
DoFn methods sample
URL: https://github.com/apache/beam/pull/9257#discussion_r310834988
##########
File path:
sdks/python/apache_beam/examples/snippets/transforms/element_wise/pardo.py
##########
@@ -29,7 +29,8 @@ def __init__(self, delimiter=','):
self.delimiter = delimiter
def process(self, text):
- return text.split(self.delimiter)
+ for word in text.split(self.delimiter):
Review comment:
It is good to keep variations in examples, for people to pick up on
different versions. Unless there is another reason, I would suggest keeping
this as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 292246)
Time Spent: 39h (was: 38h 50m)
> Colab examples for element-wise transforms (Python)
> ---------------------------------------------------
>
> Key: BEAM-7389
> URL: https://issues.apache.org/jira/browse/BEAM-7389
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Rose Nguyen
> Assignee: David Cavazos
> Priority: Minor
> Time Spent: 39h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
