[
https://issues.apache.org/jira/browse/BEAM-7854?focusedWorklogId=293460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293460
]
ASF GitHub Bot logged work on BEAM-7854:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/19 22:59
Start Date: 12/Aug/19 22:59
Worklog Time Spent: 10m
Work Description: tomerz90 commented on issue #9197: [BEAM-7854] Resolve
parent folder recursively in LocalFileSystem matc…
URL: https://github.com/apache/beam/pull/9197#issuecomment-520625379
> The failed tests get a timeout because of the issue I mentioned.
> I can modify the implementation to only search for a parent recursively if
the string contains glob wild cards, but it feels a bit fragile, if the glob
spec will be updated with new wildcards, would appreciate your thoughts on the
issue.
Thanks @lukecwik , but thats not going to help, please see the quote and the
comment before as to why
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 293460)
Time Spent: 2h 10m (was: 2h)
> Reading files from local file system does not fully support glob
> ----------------------------------------------------------------
>
> Key: BEAM-7854
> URL: https://issues.apache.org/jira/browse/BEAM-7854
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Tomer Zeltzer
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Folder structure:
> {code:java}
> A
> B
> a=100
> data1
> file1.zst
> file2.zst
> a=999
> data2
> file6.zst
> a=397
> data3
> file7.zst{code}
>
> Glob:
>
> {code:java}
> /A/B/a=[0-9][0-9][0-9]/*/*{code}
> Code:
>
> {code:java}
> input.apply(Create.of(patterns))
> .apply("Matching patterns", FileIO.matchAll())
> .apply(FileIO.readMatches());
> {code}
>
> input is of type PBegin.
> The above code matches 0 files even though, from the glob, its clear it
> should match all files. I suspect its because of line 227, where only the
> first parent folder is checked while is could be an asterix in a glob. I
> believe the right behaviour should be to check all parent folder and use the
> first one that exists.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
