[
https://issues.apache.org/jira/browse/BEAM-7854?focusedWorklogId=293464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293464
]
ASF GitHub Bot logged work on BEAM-7854:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/19 23:04
Start Date: 12/Aug/19 23:04
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9197: [BEAM-7854]
Resolve parent folder recursively in LocalFileSystem matc…
URL: https://github.com/apache/beam/pull/9197#discussion_r313163202
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/io/LocalFileSystemTest.java
##########
@@ -184,6 +184,27 @@ public void testDelete() throws Exception {
assertTrue(f3.exists());
}
+ @Test
+ public void testMatchWithGlob() throws Exception {
+ String globPattern = "/A/a=[0-9][0-9][0-9]/*/*";
+ File folder1 = temporaryFolder.newFolder("A/a=100/data1");
+ File folder2 = temporaryFolder.newFolder("A/a=233/data_dir");
+ File expectedFile1 = new File(folder1, "/file1");
Review comment:
you don't need the "/" in the file names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 293464)
Time Spent: 2h 40m (was: 2.5h)
> Reading files from local file system does not fully support glob
> ----------------------------------------------------------------
>
> Key: BEAM-7854
> URL: https://issues.apache.org/jira/browse/BEAM-7854
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Tomer Zeltzer
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Folder structure:
> {code:java}
> A
> B
> a=100
> data1
> file1.zst
> file2.zst
> a=999
> data2
> file6.zst
> a=397
> data3
> file7.zst{code}
>
> Glob:
>
> {code:java}
> /A/B/a=[0-9][0-9][0-9]/*/*{code}
> Code:
>
> {code:java}
> input.apply(Create.of(patterns))
> .apply("Matching patterns", FileIO.matchAll())
> .apply(FileIO.readMatches());
> {code}
>
> input is of type PBegin.
> The above code matches 0 files even though, from the glob, its clear it
> should match all files. I suspect its because of line 227, where only the
> first parent folder is checked while is could be an asterix in a glob. I
> believe the right behaviour should be to check all parent folder and use the
> first one that exists.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
