[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=298132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298132
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 20:03
Start Date: 20/Aug/19 20:03
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9144: [BEAM-7013]
Integrating ZetaSketch's HLL++ algorithm with Beam
URL: https://github.com/apache/beam/pull/9144#discussion_r315877325
##########
File path:
sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/HllCountTest.java
##########
@@ -0,0 +1,373 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.zetasketch;
+
+import com.google.zetasketch.HyperLogLogPlusPlus;
+import com.google.zetasketch.shaded.com.google.protobuf.ByteString;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.apache.beam.sdk.Pipeline.PipelineExecutionException;
+import org.apache.beam.sdk.testing.NeedsRunner;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.values.KV;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptor;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.ExpectedException;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/** Tests for {@link HllCount}. */
+@RunWith(JUnit4.class)
+public class HllCountTest {
+
+ @Rule public final transient TestPipeline p = TestPipeline.create();
+ @Rule public transient ExpectedException thrown = ExpectedException.none();
+
+ // Integer
+ private static final List<Integer> INTS1 = Arrays.asList(1, 2, 3, 3, 1, 4);
+ private static final byte[] INTS1_SKETCH;
+ private static final Long INTS1_ESTIMATE;
+
+ static {
+ HyperLogLogPlusPlus<Integer> hll = new
HyperLogLogPlusPlus.Builder().buildForIntegers();
+ INTS1.forEach(hll::add);
+ INTS1_SKETCH = hll.serializeToByteArray();
+ INTS1_ESTIMATE = hll.longResult();
+ }
+
+ private static final List<Integer> INTS2 = Arrays.asList(3, 3, 3, 3);
+ private static final byte[] INTS2_SKETCH;
+ private static final Long INTS2_ESTIMATE;
+
+ static {
+ HyperLogLogPlusPlus<Integer> hll = new
HyperLogLogPlusPlus.Builder().buildForIntegers();
+ INTS2.forEach(hll::add);
+ INTS2_SKETCH = hll.serializeToByteArray();
+ INTS2_ESTIMATE = hll.longResult();
+ }
+
+ private static final byte[] INTS1_INTS2_SKETCH;
+
+ static {
+ HyperLogLogPlusPlus<?> hll = HyperLogLogPlusPlus.forProto(INTS1_SKETCH);
+ hll.merge(INTS2_SKETCH);
+ INTS1_INTS2_SKETCH = hll.serializeToByteArray();
+ }
+
+ // Long
+ private static final List<Long> LONGS = Collections.singletonList(1L);
+ private static final byte[] LONGS_SKETCH;
+
+ static {
+ HyperLogLogPlusPlus<Long> hll = new
HyperLogLogPlusPlus.Builder().buildForLongs();
+ LONGS.forEach(hll::add);
+ LONGS_SKETCH = hll.serializeToByteArray();
+ }
+
+ private static final byte[] LONGS_EMPTY_SKETCH;
+
+ static {
+ HyperLogLogPlusPlus<Long> hll = new
HyperLogLogPlusPlus.Builder().buildForLongs();
+ LONGS_EMPTY_SKETCH = hll.serializeToByteArray();
+ }
+
+ // String
+ private static final List<String> STRINGS = Arrays.asList("s1", "s2", "s1",
"s2");
+ private static final byte[] STRINGS_SKETCH;
+
+ static {
+ HyperLogLogPlusPlus<String> hll = new
HyperLogLogPlusPlus.Builder().buildForStrings();
+ STRINGS.forEach(hll::add);
+ STRINGS_SKETCH = hll.serializeToByteArray();
+ }
+
+ private static final int TEST_PRECISION = 20;
+ private static final byte[] STRINGS_SKETCH_TEST_PRECISION;
+
+ static {
+ HyperLogLogPlusPlus<String> hll =
+ new
HyperLogLogPlusPlus.Builder().normalPrecision(TEST_PRECISION).buildForStrings();
+ STRINGS.forEach(hll::add);
+ STRINGS_SKETCH_TEST_PRECISION = hll.serializeToByteArray();
+ }
+
+ // Bytes
+ private static final byte[] BYTES0 = {(byte) 0x1, (byte) 0xa};
+ private static final byte[] BYTES1 = {(byte) 0xf};
+ private static final List<byte[]> BYTES = Arrays.asList(BYTES0, BYTES1);
+ private static final byte[] BYTES_SKETCH;
+
+ static {
+ HyperLogLogPlusPlus<ByteString> hll = new
HyperLogLogPlusPlus.Builder().buildForBytes();
+ BYTES.forEach(hll::add);
+ BYTES_SKETCH = hll.serializeToByteArray();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForIntegersGlobally() {
+ PCollection<byte[]> result =
+
p.apply(Create.of(INTS1)).apply(HllCount.Init.forIntegers().globally());
+
+ PAssert.thatSingleton(result).isEqualTo(INTS1_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForLongsGlobally() {
+ PCollection<byte[]> result =
+ p.apply(Create.of(LONGS)).apply(HllCount.Init.forLongs().globally());
+
+ PAssert.thatSingleton(result).isEqualTo(LONGS_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForLongsGlobally_EmptyInput() {
+ PCollection<byte[]> result =
+ p.apply(Create.empty(TypeDescriptor.of(Long.class)))
+ .apply(HllCount.Init.forLongs().globally());
+
+ PAssert.that(result).empty();
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForStringsGlobally() {
+ PCollection<byte[]> result =
+
p.apply(Create.of(STRINGS)).apply(HllCount.Init.forStrings().globally());
+
+ PAssert.thatSingleton(result).isEqualTo(STRINGS_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForStringsGlobally_WithPrecision() {
+ PCollection<byte[]> result =
+ p.apply(Create.of(STRINGS))
+
.apply(HllCount.Init.forStrings().withPrecision(TEST_PRECISION).globally());
+
+ PAssert.thatSingleton(result).isEqualTo(STRINGS_SKETCH_TEST_PRECISION);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForStringsGlobally_WithInvalidPrecision() {
+ thrown.expect(IllegalArgumentException.class);
+
p.apply(Create.of(STRINGS)).apply(HllCount.Init.forStrings().withPrecision(0).globally());
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForBytesGlobally() {
+ PCollection<byte[]> result =
+ p.apply(Create.of(BYTES)).apply(HllCount.Init.forBytes().globally());
+
+ PAssert.thatSingleton(result).isEqualTo(BYTES_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForIntegersPerKey() {
+ List<KV<String, Integer>> input = new ArrayList<>();
+ INTS1.forEach(i -> input.add(KV.of("k1", i)));
+ INTS1.forEach(i -> input.add(KV.of("k2", i)));
+ INTS2.forEach(i -> input.add(KV.of("k1", i)));
+ PCollection<KV<String, byte[]>> result =
+ p.apply(Create.of(input)).apply(HllCount.Init.forIntegers().perKey());
+
+ PAssert.that(result)
+ .containsInAnyOrder(
+ Arrays.asList(KV.of("k1", INTS1_INTS2_SKETCH), KV.of("k2",
INTS1_SKETCH)));
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForLongsPerKey() {
+ List<KV<String, Long>> input = new ArrayList<>();
+ LONGS.forEach(l -> input.add(KV.of("k", l)));
+ PCollection<KV<String, byte[]>> result =
+ p.apply(Create.of(input)).apply(HllCount.Init.forLongs().perKey());
+
+
PAssert.that(result).containsInAnyOrder(Collections.singletonList(KV.of("k",
LONGS_SKETCH)));
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForStringsPerKey() {
+ List<KV<String, String>> input = new ArrayList<>();
+ STRINGS.forEach(s -> input.add(KV.of("k", s)));
+ PCollection<KV<String, byte[]>> result =
+ p.apply(Create.of(input)).apply(HllCount.Init.forStrings().perKey());
+
+
PAssert.that(result).containsInAnyOrder(Collections.singletonList(KV.of("k",
STRINGS_SKETCH)));
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForStringsPerKey_WithPrecision() {
+ List<KV<String, String>> input = new ArrayList<>();
+ STRINGS.forEach(s -> input.add(KV.of("k", s)));
+ PCollection<KV<String, byte[]>> result =
+ p.apply(Create.of(input))
+
.apply(HllCount.Init.forStrings().withPrecision(TEST_PRECISION).perKey());
+
+ PAssert.that(result)
+ .containsInAnyOrder(Collections.singletonList(KV.of("k",
STRINGS_SKETCH_TEST_PRECISION)));
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForStringsPerKey_WithInvalidPrecision() {
+ List<KV<String, String>> input = new ArrayList<>();
+ STRINGS.forEach(s -> input.add(KV.of("k", s)));
+ thrown.expect(IllegalArgumentException.class);
+
p.apply(Create.of(input)).apply(HllCount.Init.forStrings().withPrecision(0).perKey());
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testInitForBytesPerKey() {
+ List<KV<String, byte[]>> input = new ArrayList<>();
+ BYTES.forEach(bs -> input.add(KV.of("k", bs)));
+ PCollection<KV<String, byte[]>> result =
+ p.apply(Create.of(input)).apply(HllCount.Init.forBytes().perKey());
+
+
PAssert.that(result).containsInAnyOrder(Collections.singletonList(KV.of("k",
BYTES_SKETCH)));
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testMergePartialGlobally() {
+ PCollection<byte[]> result =
+ p.apply(Create.of(INTS1_SKETCH,
INTS2_SKETCH)).apply(HllCount.MergePartial.globally());
+
+ PAssert.thatSingleton(result).isEqualTo(INTS1_INTS2_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testMergePartialGlobally_MergeWithSketchForEmptySet() {
+ PCollection<byte[]> result =
+ p.apply(Create.of(LONGS_SKETCH, LONGS_EMPTY_SKETCH))
+ .apply(HllCount.MergePartial.globally());
+
+ PAssert.thatSingleton(result).isEqualTo(LONGS_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testMergePartialGlobally_SingletonInput() {
+ PCollection<byte[]> result =
+
p.apply(Create.of(LONGS_SKETCH)).apply(HllCount.MergePartial.globally());
+
+ PAssert.thatSingleton(result).isEqualTo(LONGS_SKETCH);
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testMergePartialGlobally_EmptyInput() {
+ PCollection<byte[]> result =
+ p.apply(Create.empty(TypeDescriptor.of(byte[].class)))
+ .apply(HllCount.MergePartial.globally());
+
+ PAssert.that(result).empty();
+ p.run();
+ }
+
+ @Test
+ @Category(NeedsRunner.class)
+ public void testMergePartialGlobally_IncompatibleSketches() {
+ p.apply(Create.of(INTS1_SKETCH,
STRINGS_SKETCH)).apply(HllCount.MergePartial.globally());
+
+ thrown.expect(PipelineExecutionException.class);
+ p.run();
+ }
Review comment:
Yeah, but I think this will then become a wrapper around something like the
`merge_NormalIntoNormalWith[Higher|Lower]Precision`
[tests](https://github.com/google/zetasketch/blob/4aa44e9cb543d766318b919fc6bb359bdf7b0809/javatests/com/google/zetasketch/HyperLogLogPlusPlusTest.java#L733),
and the expected result is just that it goes through, as you mentioned. So I
would like to skip it here. Let me know if you disagree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 298132)
Time Spent: 22h (was: 21h 50m)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 22h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
