[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=298156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298156
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/19 20:37
Start Date: 20/Aug/19 20:37
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9144: [BEAM-7013]
Integrating ZetaSketch's HLL++ algorithm with Beam
URL: https://github.com/apache/beam/pull/9144#discussion_r315891168
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryMatcher.java
##########
@@ -63,32 +63,52 @@
private final String projectId;
private final String query;
+ private final boolean usingStandardSql;
Review comment:
No, BigQuery cannot tell that (or at least the BigQuery client library we
use to issue the query cannot do that). We have to tune the parameter to
explicitly specify which type of query we are using.
Link to the underlying client library code:
https://github.com/googleapis/google-api-java-client-services/blob/ed262e9fa7d950fa4e2aca65c2b765d544179859/clients/google-api-services-bigquery/v2/1.27.0/com/google/api/services/bigquery/model/QueryRequest.java#L122-L130
(called by BigQueryClient by BigQueryMatcher by the ITs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 298156)
Time Spent: 23h 10m (was: 23h)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 23h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
