[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=299183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299183
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/19 05:54
Start Date: 22/Aug/19 05:54
Worklog Time Spent: 10m
Work Description: rakeshcusat commented on pull request #9374:
[BEAM-5428] Implement Runner support for cache tokens
URL: https://github.com/apache/beam/pull/9374#discussion_r316506303
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -248,33 +253,45 @@ private StateRequestHandler
getStateRequestHandler(ExecutableStage executableSta
return StateRequestHandlers.delegateBasedUponType(handlerMap);
}
- private static class BagUserStateFactory<K extends ByteString, V, W extends
BoundedWindow>
+ static class BagUserStateFactory<K extends ByteString, V, W extends
BoundedWindow>
implements StateRequestHandlers.BagUserStateHandlerFactory<K, V, W> {
+ /** Upper limit of the number of valid cache tokens to hand out to the
SDK. */
+ private static final int MAX_CACHE_SIZE = 100;
+
private final StateInternals stateInternals;
private final KeyedStateBackend<ByteBuffer> keyedStateBackend;
private final Lock stateBackendLock;
+ /** Cache is scoped by state id. */
Review comment:
is it possible that there are two DoFns in the pipeline and they
accidentally using the same state id? In this case there could be collision of
stateid. I think we also need other parameters in the cache key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 299183)
Time Spent: 40m (was: 0.5h)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
