[
https://issues.apache.org/jira/browse/BEAM-5428?focusedWorklogId=299191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299191
]
ASF GitHub Bot logged work on BEAM-5428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/19 06:12
Start Date: 22/Aug/19 06:12
Worklog Time Spent: 10m
Work Description: rakeshcusat commented on pull request #9374:
[BEAM-5428] Implement Runner support for cache tokens
URL: https://github.com/apache/beam/pull/9374#discussion_r316509961
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/state/InMemoryBagUserStateFactory.java
##########
@@ -80,29 +82,33 @@ public void resetForNewKey() {
}
@Override
- public Iterable<V> get(K key, W window) {
+ public BagWithCacheToken<V> get(K key, W window) {
initStateInternals(key);
StateNamespace namespace = StateNamespaces.window(windowCoder, window);
BagState<V> bagState = stateInternals.state(namespace, stateTag);
- return bagState.read();
+ return new BagWithCacheToken<>(bagState.read(), null);
}
@Override
- public void append(K key, W window, Iterator<V> values) {
+ @Nullable
+ public ByteString append(K key, W window, Iterator<V> values) {
initStateInternals(key);
StateNamespace namespace = StateNamespaces.window(windowCoder, window);
BagState<V> bagState = stateInternals.state(namespace, stateTag);
while (values.hasNext()) {
bagState.add(values.next());
}
+ return null;
Review comment:
just for consistency I would have similar cache token implementation for
this class as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 299191)
Time Spent: 1h 20m (was: 1h 10m)
> Implement cross-bundle state caching.
> -------------------------------------
>
> Key: BEAM-5428
> URL: https://issues.apache.org/jira/browse/BEAM-5428
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Robert Bradshaw
> Assignee: Rakesh Kumar
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Tech spec:
> [https://docs.google.com/document/d/1BOozW0bzBuz4oHJEuZNDOHdzaV5Y56ix58Ozrqm2jFg/edit#heading=h.7ghoih5aig5m]
> Relevant document:
> [https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit#|https://docs.google.com/document/d/1ltVqIW0XxUXI6grp17TgeyIybk3-nDF8a0-Nqw-s9mY/edit]
> Mailing list link:
> [https://lists.apache.org/thread.html/caa8d9bc6ca871d13de2c5e6ba07fdc76f85d26497d95d90893aa1f6@%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
