[
https://issues.apache.org/jira/browse/BEAM-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914456#comment-16914456
]
Rahul Patwari commented on BEAM-6114:
-------------------------------------
[~amaliujia]
My understanding is that, even with allowing triggering once, for
SideInputLookupJoin,
* LEFT OUTER Join is not supported when the left side of the join is Seekable
* RIGHT OUTER Join is not supported when the right side of the join is
Seekable.
* FULL OUTER Join is not supported.
This is similar to SideInputJoin where we are [throwing
exceptions|https://github.com/apache/beam/blob/dc63296c36e67293662c7e5857da80e6d278d5f1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSideInputJoinRel.java#L83]
for UnSupported Join types. But there are no such exceptions for
SideInputLookupJoin. So, I wanted to know if it is okay to throw Exceptions for
SideInputLookupJoin for unsupported Join Types.
> SQL join selection should be done in planner, not in expansion to PTransform
> ----------------------------------------------------------------------------
>
> Key: BEAM-6114
> URL: https://issues.apache.org/jira/browse/BEAM-6114
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Rahul Patwari
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently Beam SQL joins all go through a single physical operator which has
> a single PTransform that does all join algorithms based on properties of its
> input PCollections as well as the relational algebra.
> A first step is to make the needed information part of the relational
> algebra, so it can choose a PTransform based on that, and the PTransforms can
> be simpler.
> Second step is to have separate (physical) relational operators for different
> join algorithms.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
