[ https://issues.apache.org/jira/browse/BEAM-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914535#comment-16914535 ]
Rahul Patwari commented on BEAM-6114: ------------------------------------- To support all types of Joins with Seekable Join Bounded, we have to enhance [BeamJoinTransforms.JoinAsLookup|[https://github.com/apache/beam/blob/ad92513154fca8a7ef0a2f44b9ff54c005cbc565/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java#L175]. as the current logic for [LookupJoin|https://github.com/apache/beam/blob/ad92513154fca8a7ef0a2f44b9ff54c005cbc565/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java#L236] doesn't take care of all the join types.|https://github.com/apache/beam/blob/ad92513154fca8a7ef0a2f44b9ff54c005cbc565/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java#L175].] We also have to introduce a method in [BeamSqlSeekableTable|https://github.com/apache/beam/blob/862b04c100360c58fb4e867d97d9c49525286874/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java#L30] to get all the rows. And we have to > SQL join selection should be done in planner, not in expansion to PTransform > ---------------------------------------------------------------------------- > > Key: BEAM-6114 > URL: https://issues.apache.org/jira/browse/BEAM-6114 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Kenneth Knowles > Assignee: Rahul Patwari > Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Currently Beam SQL joins all go through a single physical operator which has > a single PTransform that does all join algorithms based on properties of its > input PCollections as well as the relational algebra. > A first step is to make the needed information part of the relational > algebra, so it can choose a PTransform based on that, and the PTransforms can > be simpler. > Second step is to have separate (physical) relational operators for different > join algorithms. -- This message was sent by Atlassian Jira (v8.3.2#803003)