[
https://issues.apache.org/jira/browse/BEAM-8080?focusedWorklogId=300467&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300467
]
ASF GitHub Bot logged work on BEAM-8080:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/19 19:53
Start Date: 23/Aug/19 19:53
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9414: [BEAM-8080]
[SQL] Fix relocation of com.google.types
URL: https://github.com/apache/beam/pull/9414#discussion_r317280131
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -49,6 +50,7 @@ applyJavaNature(
relocate "com.google.logging", getJavaRelocatedPath("com.google.logging")
relocate "com.google.longrunning",
getJavaRelocatedPath("com.google.longrunning")
relocate "com.google.rpc", getJavaRelocatedPath("com.google.rpc")
+ relocate "com.google.api", getJavaRelocatedPath("com.google.api")
Review comment:
I deleted this line because it breaks the SQL postcommit.
Honestly I am not sure how this line fix BEAM-8080. Could we have a minimal
relocation(or a minimal exclude relocation) to both fix BEAM-8080 and pass the
SQL postcommit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 300467)
Time Spent: 40m (was: 0.5h)
> java.lang.NoClassDefFoundError:
> org/apache/beam/repackaged/sql/com/google/type/Date
> -----------------------------------------------------------------------------------
>
> Key: BEAM-8080
> URL: https://issues.apache.org/jira/browse/BEAM-8080
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Gleb Kanterov
> Assignee: Gleb Kanterov
> Priority: Critical
> Fix For: 2.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code}
> java.lang.NoClassDefFoundError:
> org/apache/beam/repackaged/sql/com/google/type/Date
> at
> org.apache.beam.repackaged.sql.com.google.zetasql.SimpleCatalog.processGetBuiltinFunctionsResponse(SimpleCatalog.java:380)
> at
> org.apache.beam.repackaged.sql.com.google.zetasql.SimpleCatalog.addZetaSQLFunctions(SimpleCatalog.java:365)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer.addBuiltinFunctionsToCatalog(SqlAnalyzer.java:146)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer.createPopulatedCatalog(SqlAnalyzer.java:130)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer.analyze(SqlAnalyzer.java:90)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer$Builder.analyze(SqlAnalyzer.java:275)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLPlannerImpl.rel(ZetaSQLPlannerImpl.java:135)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.parseQuery(ZetaSQLQueryPlanner.java:92)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.parseQuery(ZetaSQLQueryPlanner.java:87)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRel(ZetaSQLQueryPlanner.java:66)
> at
> org.apache.beam.sdk.extensions.sql.impl.BeamSqlEnv.parseQuery(BeamSqlEnv.java:103)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
