[
https://issues.apache.org/jira/browse/BEAM-8080?focusedWorklogId=301214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301214
]
ASF GitHub Bot logged work on BEAM-8080:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/19 12:18
Start Date: 26/Aug/19 12:18
Worklog Time Spent: 10m
Work Description: kanterov commented on issue #9414: [BEAM-8080] [SQL]
Fix relocation of com.google.types
URL: https://github.com/apache/beam/pull/9414#issuecomment-524837655
@amaliujia I added relocation of classes in com.google.api because they are
part of the proto jar that we shade, but then it broke datacatalog that uses
GCP IO-s. Today I took a deeper look, and it seems classes from com.google.type
are part of ZetaSQL public API, and therefore, they shouldn't be shaded at all,
so I just removed it.
In general, It doesn't feel right to have Google protos in dependencies for
SQL module, but I guess it would be fixed when we extract ZetaSQL into its own
module, the same applies to other code like datacatalog table providers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 301214)
Time Spent: 1h 10m (was: 1h)
> java.lang.NoClassDefFoundError:
> org/apache/beam/repackaged/sql/com/google/type/Date
> -----------------------------------------------------------------------------------
>
> Key: BEAM-8080
> URL: https://issues.apache.org/jira/browse/BEAM-8080
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Gleb Kanterov
> Assignee: Gleb Kanterov
> Priority: Critical
> Fix For: 2.16.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code}
> java.lang.NoClassDefFoundError:
> org/apache/beam/repackaged/sql/com/google/type/Date
> at
> org.apache.beam.repackaged.sql.com.google.zetasql.SimpleCatalog.processGetBuiltinFunctionsResponse(SimpleCatalog.java:380)
> at
> org.apache.beam.repackaged.sql.com.google.zetasql.SimpleCatalog.addZetaSQLFunctions(SimpleCatalog.java:365)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer.addBuiltinFunctionsToCatalog(SqlAnalyzer.java:146)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer.createPopulatedCatalog(SqlAnalyzer.java:130)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer.analyze(SqlAnalyzer.java:90)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.SqlAnalyzer$Builder.analyze(SqlAnalyzer.java:275)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLPlannerImpl.rel(ZetaSQLPlannerImpl.java:135)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.parseQuery(ZetaSQLQueryPlanner.java:92)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.parseQuery(ZetaSQLQueryPlanner.java:87)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRel(ZetaSQLQueryPlanner.java:66)
> at
> org.apache.beam.sdk.extensions.sql.impl.BeamSqlEnv.parseQuery(BeamSqlEnv.java:103)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
